Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java 23 #27345

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Add support for Java 23 #27345

merged 7 commits into from
Oct 28, 2024

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Sep 20, 2024

https://jdk.java.net/23/release-notes


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

README.md Outdated Show resolved Hide resolved
@mraible mraible enabled auto-merge (squash) September 21, 2024 21:23
@mraible mraible closed this Sep 23, 2024
auto-merge was automatically disabled September 23, 2024 03:58

Pull request was closed

@mraible mraible reopened this Sep 23, 2024
@mraible
Copy link
Contributor Author

mraible commented Sep 23, 2024

WebFlux tests are failing because of Byte Buddy:

[Byte Buddy] ERROR java.text.Format$FieldDelegate [null, module java.base, Thread[#1,main,5,main], loaded=false]
java.lang.IllegalArgumentException: Java 23 (67) is not supported by the current version of Byte Buddy which officially 
supports Java 22 (66) - update Byte Buddy or set reactor.blockhound.shaded.net.bytebuddy.experimental as a VM property

@mraible
Copy link
Contributor Author

mraible commented Oct 28, 2024

When using JDK 23 and starting the default generated app, there are stack traces, but everything starts up OK.

2024-10-27T21:30:16.837-06:00 DEBUG 82562 --- [  restartedMain] java.lang.ProcessBuilder                 : ProcessBuilder.start(): pid: 82581, dir: null, cmd: "docker"

java.lang.RuntimeException: ProcessBuilder.start() debug
	at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1147)
	at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1089)
	at org.springframework.boot.docker.compose.core.ProcessRunner.startProcess(ProcessRunner.java:106)
	at org.springframework.boot.docker.compose.core.ProcessRunner.run(ProcessRunner.java:88)
	at org.springframework.boot.docker.compose.core.DockerCli.run(DockerCli.java:80)
	at org.springframework.boot.docker.compose.core.DefaultDockerCompose.inspect(DefaultDockerCompose.java:93)
	at org.springframework.boot.docker.compose.core.DefaultDockerCompose.getRunningServices(DefaultDockerCompose.java:82)
	at org.springframework.boot.docker.compose.lifecycle.DockerComposeLifecycleManager.start(DockerComposeLifecycleManager.java:129)
	at org.springframework.boot.docker.compose.lifecycle.DockerComposeListener.onApplicationEvent(DockerComposeListener.java:53)
	at org.springframework.boot.docker.compose.lifecycle.DockerComposeListener.onApplicationEvent(DockerComposeListener.java:35)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:185)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:178)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:156)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:138)
	at org.springframework.boot.context.event.EventPublishingRunListener.multicastInitialEvent(EventPublishingRunListener.java:136)
	at org.springframework.boot.context.event.EventPublishingRunListener.contextLoaded(EventPublishingRunListener.java:98)
	at org.springframework.boot.SpringApplicationRunListeners.lambda$contextLoaded$4(SpringApplicationRunListeners.java:72)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:118)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:112)
	at org.springframework.boot.SpringApplicationRunListeners.contextLoaded(SpringApplicationRunListeners.java:72)
	at org.springframework.boot.SpringApplication.prepareContext(SpringApplication.java:433)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:334)
	at com.mycompany.myapp.DefApp.main(DefApp.java:70)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:50)

2024-10-27T21:30:17.929-06:00 DEBUG 82562 --- [  restartedMain] c.mycompany.myapp.config.WebConfigurer   : Registering CORS filter

I'm using Docker version 27.3.1, build ce12230.

@mraible
Copy link
Contributor Author

mraible commented Oct 28, 2024

This stack trace is printed with JDK 22 as well, but not with JDK 17.

@mraible mraible closed this Oct 28, 2024
@mraible mraible reopened this Oct 28, 2024
@mraible mraible mentioned this pull request Oct 28, 2024
1 task
@mraible
Copy link
Contributor Author

mraible commented Oct 28, 2024

@mshima The ng-default job is failing with the following error:

Error: You are running an incompatible version of Java. JHipster supports JDK 17 to 22.

Do you know why this happens?

@mshima
Copy link
Member

mshima commented Oct 28, 2024

@mshima The ng-default job is failing with the following error:

Error: You are running an incompatible version of Java. JHipster supports JDK 17 to 22.

Do you know why this happens?

@mraible sonar steps runs tests using main branch to be able to create issues diff.

@mraible mraible merged commit 037076f into main Oct 28, 2024
62 checks passed
@mraible mraible deleted the java-23 branch October 28, 2024 15:49
mraible added a commit that referenced this pull request Oct 28, 2024
@mraible mraible added this to the 8.7.2 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants