Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't convert blob types in jdl #27328

Merged
merged 9 commits into from
Sep 19, 2024
Merged

don't convert blob types in jdl #27328

merged 9 commits into from
Sep 19, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented Sep 18, 2024

JDL currently converts *Blob types to byte[] and contentType.
Move conversion to generators.

Improve field types.

I think we can close #27136 and #26114.
Close #26114
Close #27136


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review September 19, 2024 16:01
@DanielFran DanielFran merged commit 67d9b6b into jhipster:main Sep 19, 2024
56 checks passed
@mshima mshima deleted the blob branch September 20, 2024 17:09
@mraible mraible added this to the 8.7.1 milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple JDL from generators. Use type checking within the generator
3 participants