-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bit of code improvement #27289
base: main
Are you sure you want to change the base?
A bit of code improvement #27289
Conversation
Is it considered as correct? I'm a bit reluctant to continue this PR to improve the remaining files (passing over each generator with the same improvments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea is to drop lib/jhipster/index.js
.
Choice value usage will be at the generator it's declared.
It can be replaced with something like springBootCommand.configs.authenticationType.choices.jwt.value
.
Choices is an array, we should support object.
Can we simplify? |
First try to follow #27294
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.