-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusts for embedded entities #25976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshima
force-pushed
the
embedded-otherEntity
branch
from
April 26, 2024 22:46
5f9a328
to
a3ddefa
Compare
mshima
force-pushed
the
embedded-otherEntity
branch
2 times, most recently
from
April 26, 2024 22:58
d701526
to
8c9854d
Compare
mshima
changed the title
don't try to generate select for embedded entities.
adjusts for embedded entities
Apr 27, 2024
mshima
force-pushed
the
embedded-otherEntity
branch
2 times, most recently
from
April 29, 2024 14:55
d0d3729
to
e21818a
Compare
mshima
force-pushed
the
embedded-otherEntity
branch
from
April 30, 2024 12:17
e21818a
to
ac70695
Compare
mshima
force-pushed
the
embedded-otherEntity
branch
from
May 16, 2024 14:03
c6a6605
to
33d31a1
Compare
DanielFran
approved these changes
May 16, 2024
@mshima Seems that this breaks the daily builds... Any thought? |
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22748
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.