-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject db gradle dependencies using api #25504
Conversation
@@ -49,7 +41,7 @@ configurations { | |||
} | |||
|
|||
dependencies { | |||
developmentOnly "org.springframework.boot:spring-boot-devtools:${springBootVersion}" | |||
compileOnly "org.springframework.boot:spring-boot-devtools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what's the reason for this change (developmentOnly
-> compileOnly
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test with developmentOnly again since its recommended by updated spring-boot.
compileOnly "org.springframework.boot:spring-boot-devtools" | |
developmentOnly "org.springframework.boot:spring-boot-devtools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails to generate a package with dev profile due to springBootVersion property removal.
See https://github.com/jhipster/generator-jhipster/actions/runs/8316726401/job/22756588401?pr=25504
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.