Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add German translation keys for cache metrics #24994

Merged

Conversation

timothystone-knsl
Copy link
Contributor

@timothystone-knsl timothystone-knsl commented Jan 29, 2024

The German translation keys for Metrics is missing nine keys. Add the translation keys. Translations provided by Markus Bernhardt.

An additional key missing in the global.json is also provided.

See #24993

Fixes #24993


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

The German translation keys for Metrics is missing nine keys. Add the translation keys. Translations
provided by Markus Bernhardt.

An additional key missing in the global.json is also provided.
@mraible mraible merged commit e544a28 into jhipster:main Jan 29, 2024
52 checks passed
@timothystone-knsl timothystone-knsl deleted the refactor/add-cache-keys-to-de branch January 29, 2024 16:28
@timothystone-knsl
Copy link
Contributor Author

🙏 @mraible for such quick resolution!

"puts": "Anzahl geschriebener Objekte",
"removals": "Anzahl gelöschter Objekte",
"evictions": "Anzahl entfernter Objekte",
"hitPercent": "Trefferwahrscheinlichkeit %",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a native german speaker I think this is not totally correct. I think the metric describes the hit and miss ratio and not the hit or miss probability. So maybe "(Cache)-Treffer %" and "(Cache)-Fehler %".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A native German speaker in Munich did the translations; I ran the PR submission.

The missing keys came up in a Gitter conversation. I'm not so invested in the debate of the translation as the missing keys. With the keys in place, a discussion of the translation is fair game @atomfrede .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the actual translation is not that important and easy to change. Thanks for the pr!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I think it should be "(Cache)-Treffer %" or "Trefferquote %".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem fine. Cache-Treffer is close to to the english one, while Trefferquote would be more common german wording. I would go with trefferquote maybe.

@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

German i18n missing translation keys
5 participants