fix ci-cd prompts #24568
Merged
fix ci-cd prompts #24568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomfrede
previously approved these changes
Dec 14, 2023
mshima
force-pushed
the
ci-cd-prompts
branch
from
b56f050
to
8bc15c5
Compare
DanielFran
reviewed
Dec 15, 2023
| @@ -133,7 +133,7 @@ const command: JHipsterCommandDefinition = { | |||
| }, | |||
| sonarName: { | |||
| prompt: { | |||
| when: answers => includesValue('ciCd', ['jenkins'])(answers) && includesValue('ciCdIntegrations', ['ciCdIntegrations'])(answers), | |||
| when: answers => includesValue('ciCd', ['jenkins'])(answers) && includesValue('ciCdIntegrations', ['sonar'])(answers), | |||
There was a problem hiding this comment.
@mshima It should includes also 'github', 'gitlab', 'travis'?
There was a problem hiding this comment.
I didn’t find any usage for those.
https://github.com/search?q=repo%3Ajhipster%2Fgenerator-jhipster%20sonarName&type=code
There was a problem hiding this comment.
Even not sure travis is well or maintained at all. I haven't used it for a long time.
atomfrede
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24564
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.