Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spring Boot 3.2 #24098

Merged
merged 66 commits into from
Dec 7, 2023
Merged

Upgrade to Spring Boot 3.2 #24098

merged 66 commits into from
Dec 7, 2023

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Nov 4, 2023 •
edited
Loading

Verifies that jhipster/jhipster-bom#1460 works.
Fixes #24091.

Please make sure the below checklist is followed for Pull Requests.

@mraible
Copy link
Contributor Author

mraible commented Nov 20, 2023

Closing and re-opening to test updates to jhipster-bom.

@mraible mraible closed this Nov 20, 2023
@mraible mraible reopened this Nov 20, 2023
@mraible
Copy link
Contributor Author

mraible commented Nov 21, 2023

Trying again because jhipster-bom has fixes. Please let me know if there's an easier way than closing/reopening.

@mraible mraible closed this Nov 21, 2023
@mraible mraible reopened this Nov 21, 2023
@mraible
Copy link
Contributor Author

mraible commented Nov 21, 2023 •
edited
Loading

It seems kinda strange that we have to add the name argument to @RequestParam for Spring Boot 3.2. See 56cebf9. I found the answer here.

/cc @mshima and @hide212131 since I know we had to do this for the generator-jhipster-native blueprint. It might not be necessary in the blueprint once this PR is merged.

@mraible
Copy link
Contributor Author

mraible commented Nov 21, 2023

I'm not able to reproduce the errors in the ng-webflux-psql-additional job locally.

java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/ser/std/StdArraySerializers$DoubleArraySerializer

@mraible
Change from deprecated UriComponentsBuilder.fromHttpRequest() to Forw…
e7fcd7d 
…ardedHeaderUtils.adaptFromForwardedHeaders(request.getURI(), request.getHeaders())
@mshima
Copy link
Member

mshima commented Nov 21, 2023

It seems kinda strange that we have to add the name argument to @RequestParam for Spring Boot 3.2. See 56cebf9. I found the answer here.

I wonder if it’s related to #24295

/cc @mshima and @hide212131 since I know we had to do this for the generator-jhipster-native blueprint. It might not be necessary in the blueprint once this PR is merged.

Great. Maybe there are more customizations to move to main generator.

@mraible
Copy link
Contributor Author

mraible commented Nov 21, 2023

I wonder if it’s related to #24295

I believe it is.

@DanielFran
Copy link
Member

DanielFran commented Nov 21, 2023 •
edited
Loading

@mraible we should be able to do a new release after November 28 based on the spring-cloud release
image

@mraible
Copy link
Contributor Author

mraible commented Dec 6, 2023

FWIW, I didn't mean to do a rebase and add all the commits from main individually. Doh!

@mraible mraible marked this pull request as ready for review December 6, 2023 22:58
@mshima mshima enabled auto-merge (squash) December 7, 2023 02:02
@mraible
Copy link
Contributor Author

mraible commented Dec 7, 2023 •
edited
Loading

ms-ng-consul-oauth2-mongodb-caffeine seems to be a blocker. If it fails regularly, I'm fine with ignoring it.

@mraible
Copy link
Contributor Author

mraible commented Dec 7, 2023

Might be a Kafka issue now?

@DanielFran
Copy link
Member

Might be a Kafka issue now?

It seems, yes https://github.com/jhipster/generator-jhipster/actions/runs/7122578110/job/19395489593#step:18:712

image

@DanielFran
Copy link
Member

DanielFran commented Dec 7, 2023 •
edited
Loading

Since BOM has been merged, let's merge it too and work separately on that issue

@DanielFran DanielFran merged commit 3d78e7e into main Dec 7, 2023
50 of 52 checks passed
@DanielFran DanielFran deleted the spring-boot-3.2 branch December 7, 2023 08:53
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
@hide212131 hide212131 mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielFran DanielFran DanielFran approved these changes

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
theme: CI builds theme: java theme: jhipster-internals
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Boot 3.2
4 participants
@mraible @mshima @DanielFran @deepu105