Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common web fonts to security configs #23142

Closed
wants to merge 1 commit into from

Conversation

dinu0000
Copy link
Contributor

@dinu0000 dinu0000 commented Aug 11, 2023

fix #22855


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mraible
Copy link
Contributor

mraible commented Aug 16, 2023

Can you please provide a situation that this fixes? We don't include any fonts that match "/*.woff", "/*.woff2", "/*.ttf", "/*.otf" by default, so I'm not sure why this is needed.

@dinu0000
Copy link
Contributor Author

This will be useful when user adds custom styles and fonts.

@mraible
Copy link
Contributor

mraible commented Aug 16, 2023

This will be useful when user adds custom styles and fonts.

If a user adds custom fonts, they should also allow them in their security configuration. That's my opinion. I'm not sure we should allow things that a user might add.

@mraible
Copy link
Contributor

mraible commented Aug 17, 2023

@dinu0000 This would be better integrated as a tip. Can you please add a PR to the website repo to add this tip?

https://www.jhipster.tech/tips/

I'm closing this PR. Please reopen if you feel strongly that it should be added.

@dinu0000
Copy link
Contributor Author

PR for TIP created jhipster/jhipster.github.io#1300

@deepu105 deepu105 added this to the 8.0.0-beta.3 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts extensions now allowed by default
3 participants