Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Generator development setup #22808

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

jelharou
Copy link
Contributor

@jelharou jelharou commented Jul 8, 2023

Update documentation for Generator development setup in CONTRIBUTING.md

Change order so that npm ci is run before npm link.
Close #22732


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

document that `npm ci` should be run before `npm link`

Fix jhipster#22732
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2023

CLA assistant check
All committers have signed the CLA.

@DanielFran DanielFran closed this Jul 9, 2023
@DanielFran DanielFran reopened this Jul 9, 2023
@DanielFran DanielFran merged commit 3ada22b into jhipster:main Jul 9, 2023
@DanielFran
Copy link
Member

Thanks @jelharou for the contribution

@jelharou jelharou deleted the document-npm-ci-before-link branch July 9, 2023 13:15
@jelharou
Copy link
Contributor Author

jelharou commented Jul 9, 2023

I have claimed the bug bounty: https://opencollective.com/generator-jhipster/expenses/148921

@DanielFran
Copy link
Member

@jelharou approved

@DanielFran DanielFran added this to the 8.0.0-beta.2 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Development setup instructions seem to be incomplete
3 participants