Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move multistep transform to a dedicated priority #21085

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Feb 12, 2023

Multi-step should be applied between writing and postWriting, so that needles will be applied to fully rendered files at postWriting.
We are currently using the transform priority provided by yeoman for multi-step. This breaks queueTransform because it will be applied to not fully rendered files.

  • create a new priority for multi-step executed between writing and postWriting.
  • move transform priority to after postWriting.

related to #21080


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 92b23d6 into jhipster:main Feb 13, 2023
@mshima mshima deleted the skip_ci-multistep-transform branch February 13, 2023 09:26
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants