Apply suggestions from code review

jhipster · Dec 29, 2023 · f5ca452 · f5ca452
1 parent 8fe1e01
commit f5ca452
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...emplates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.component.ts.ejs b/...emplates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.component.ts.ejs
@@ -240,9 +240,9 @@ _%>
 
   <%_ } _%>
   <%_ if (relationshipsContainManyToOne) { _%>
-    getSelected(selectedVals, option) : any {
+    getSelected(selectedVals, option, pkField = 'id') : any {
       if (selectedVals) {
-        return selectedVals.find(value => option.<%= primaryKey.name %> === value.<%= primaryKey.name %>) ?? option;
+        return selectedVals.find(value => option[pkField] === value[pkField]) ?? option;
       }
       return option;
     },

diff --git a/...ors/vue/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.vue.ejs b/...ors/vue/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.vue.ejs
@@ -146,7 +146,7 @@ _%>
                     <div class="form-group">
                         <label v-text="t$('<%= translationKey %>')" for="<%= entityFileName %>-<%= relationshipName %>"><%= relationshipNameHumanized %></label>
                         <select class="form-control" id="<%= entityFileName %>-<%= relationshipFieldNamePlural %>" data-cy="<%= relationshipFieldName %>" multiple name="<%= relationshipName %>" v-if="<%=entityInstance %>.<%=relationshipFieldNamePlural %> !== undefined" v-model="<%=entityInstance %>.<%=relationshipFieldNamePlural %>"<% if (relationshipRequired) { %> required<% } %>>
-                            <option v-bind:value="getSelected(<%=entityInstance %>.<%=relationshipFieldNamePlural %>, <%=otherEntityName %>Option)" v-for="<%=otherEntityName %>Option in <%=otherEntityNamePlural %>" :key="<%=otherEntityName %>Option.<%= relationship.otherEntity.primaryKey.name %>">{{<%=otherEntityName %>Option.<%=otherEntityField %>}}</option>
+                            <option v-bind:value="getSelected(<%=entityInstance %>.<%=relationshipFieldNamePlural %>, <%=otherEntityName %>Option, '<%= relationship.otherEntity.primaryKey.name %>')" v-for="<%=otherEntityName %>Option in <%=otherEntityNamePlural %>" :key="<%=otherEntityName %>Option.<%= relationship.otherEntity.primaryKey.name %>">{{<%=otherEntityName %>Option.<%=otherEntityField %>}}</option>
                         </select>
                     </div>
   <%_ } _%>