Skip to content

Commit

Permalink
Merge pull request #25082 from timothystone-knsl/fix/remove-eclipse-a…
Browse files Browse the repository at this point in the history
…nd-idea-plugins

fix: remove the use of the Eclipse and IDEA plugins
  • Loading branch information
murdos authored Feb 4, 2024
2 parents 0c8f955 + f87c4bb commit 83de443
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 45 deletions.
6 changes: 0 additions & 6 deletions generators/app/__snapshots__/generator.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -500,10 +500,8 @@ exports[`generator - app with default config should match snapshot 1`] = `
"maven-checkstyle-plugin": "'MAVEN-CHECKSTYLE-PLUGIN-VERSION'",
"maven-clean-plugin": "'MAVEN-CLEAN-PLUGIN-VERSION'",
"maven-compiler-plugin": "'MAVEN-COMPILER-PLUGIN-VERSION'",
"maven-eclipse-plugin": "'MAVEN-ECLIPSE-PLUGIN-VERSION'",
"maven-enforcer-plugin": "'MAVEN-ENFORCER-PLUGIN-VERSION'",
"maven-failsafe-plugin": "'MAVEN-FAILSAFE-PLUGIN-VERSION'",
"maven-idea-plugin": "'MAVEN-IDEA-PLUGIN-VERSION'",
"maven-jar-plugin": "'MAVEN-JAR-PLUGIN-VERSION'",
"maven-javadoc-plugin": "'MAVEN-JAVADOC-PLUGIN-VERSION'",
"maven-resources-plugin": "'MAVEN-RESOURCES-PLUGIN-VERSION'",
Expand Down Expand Up @@ -1073,10 +1071,8 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"maven-checkstyle-plugin": "'MAVEN-CHECKSTYLE-PLUGIN-VERSION'",
"maven-clean-plugin": "'MAVEN-CLEAN-PLUGIN-VERSION'",
"maven-compiler-plugin": "'MAVEN-COMPILER-PLUGIN-VERSION'",
"maven-eclipse-plugin": "'MAVEN-ECLIPSE-PLUGIN-VERSION'",
"maven-enforcer-plugin": "'MAVEN-ENFORCER-PLUGIN-VERSION'",
"maven-failsafe-plugin": "'MAVEN-FAILSAFE-PLUGIN-VERSION'",
"maven-idea-plugin": "'MAVEN-IDEA-PLUGIN-VERSION'",
"maven-jar-plugin": "'MAVEN-JAR-PLUGIN-VERSION'",
"maven-javadoc-plugin": "'MAVEN-JAVADOC-PLUGIN-VERSION'",
"maven-resources-plugin": "'MAVEN-RESOURCES-PLUGIN-VERSION'",
Expand Down Expand Up @@ -1646,10 +1642,8 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"maven-checkstyle-plugin": "'MAVEN-CHECKSTYLE-PLUGIN-VERSION'",
"maven-clean-plugin": "'MAVEN-CLEAN-PLUGIN-VERSION'",
"maven-compiler-plugin": "'MAVEN-COMPILER-PLUGIN-VERSION'",
"maven-eclipse-plugin": "'MAVEN-ECLIPSE-PLUGIN-VERSION'",
"maven-enforcer-plugin": "'MAVEN-ENFORCER-PLUGIN-VERSION'",
"maven-failsafe-plugin": "'MAVEN-FAILSAFE-PLUGIN-VERSION'",
"maven-idea-plugin": "'MAVEN-IDEA-PLUGIN-VERSION'",
"maven-jar-plugin": "'MAVEN-JAR-PLUGIN-VERSION'",
"maven-javadoc-plugin": "'MAVEN-JAVADOC-PLUGIN-VERSION'",
"maven-resources-plugin": "'MAVEN-RESOURCES-PLUGIN-VERSION'",
Expand Down
12 changes: 0 additions & 12 deletions generators/server/resources/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,8 @@
<maven-checkstyle-plugin.version>3.3.1</maven-checkstyle-plugin.version>
<maven-clean-plugin.version>3.3.2</maven-clean-plugin.version>
<maven-compiler-plugin.version>3.12.1</maven-compiler-plugin.version>
<maven-eclipse-plugin.version>2.10</maven-eclipse-plugin.version>
<maven-enforcer-plugin.version>3.4.1</maven-enforcer-plugin.version>
<maven-failsafe-plugin.version>3.2.5</maven-failsafe-plugin.version>
<maven-idea-plugin.version>2.2.1</maven-idea-plugin.version>
<maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
<maven-javadoc-plugin.version>3.6.3</maven-javadoc-plugin.version>
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
Expand Down Expand Up @@ -210,11 +208,6 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<version>${maven-eclipse-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Expand All @@ -225,11 +218,6 @@
<artifactId>maven-failsafe-plugin</artifactId>
<version>${maven-failsafe-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-idea-plugin</artifactId>
<version>${maven-idea-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
Expand Down
27 changes: 0 additions & 27 deletions generators/server/templates/pom.xml.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,8 @@
<maven-checkstyle-plugin.version><%- javaDependencies['maven-checkstyle-plugin'] %></maven-checkstyle-plugin.version>
<maven-clean-plugin.version><%- javaDependencies['maven-clean-plugin'] %></maven-clean-plugin.version>
<maven-compiler-plugin.version><%- javaDependencies['maven-compiler-plugin'] %></maven-compiler-plugin.version>
<maven-eclipse-plugin.version><%- javaDependencies['maven-eclipse-plugin'] %></maven-eclipse-plugin.version>
<maven-enforcer-plugin.version><%- javaDependencies['maven-enforcer-plugin'] %></maven-enforcer-plugin.version>
<maven-failsafe-plugin.version><%- javaDependencies['maven-failsafe-plugin'] %></maven-failsafe-plugin.version>
<maven-idea-plugin.version><%- javaDependencies['maven-idea-plugin'] %></maven-idea-plugin.version>
<maven-javadoc-plugin.version><%- javaDependencies['maven-javadoc-plugin'] %></maven-javadoc-plugin.version>
<maven-jar-plugin.version><%- javaDependencies['maven-jar-plugin'] %></maven-jar-plugin.version>
<maven-resources-plugin.version><%- javaDependencies['maven-resources-plugin'] %></maven-resources-plugin.version>
Expand Down Expand Up @@ -385,10 +383,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Expand All @@ -397,10 +391,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-idea-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
Expand Down Expand Up @@ -709,15 +699,6 @@
<artifactId>maven-site-plugin</artifactId>
<version>${maven-site-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<version>${maven-eclipse-plugin.version}</version>
<configuration>
<downloadSources>true</downloadSources>
<downloadJavadocs>true</downloadJavadocs>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Expand Down Expand Up @@ -755,14 +736,6 @@
</rules>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-idea-plugin</artifactId>
<version>${maven-idea-plugin.version}</version>
<configuration>
<exclude>node_modules</exclude>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
Expand Down

0 comments on commit 83de443

Please sign in to comment.