update linting job

[danieleades]

the old 'clippy-check' action is no longer maintained

[codecov-commenter]

Codecov Report

Base: 64.08% // Head: 64.30% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (09073ac) compared to base (bfa307c).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   64.08%   64.30%   +0.22%     
==========================================
  Files          82       82              
  Lines        6782     6777       -5     
==========================================
+ Hits         4346     4358      +12     
+ Misses       2436     2419      -17     

Impacted Files	Coverage Δ
src/dds/with_key/datasample.rs	16.66% <0.00%> (-8.34%)	⬇️
src/structure/locator.rs	63.82% <0.00%> (-2.18%)	⬇️
src/ros2/builtin_datatypes.rs	36.00% <0.00%> (-0.74%)	⬇️
src/structure/dds_cache.rs	52.74% <0.00%> (-0.52%)	⬇️
src/discovery/data_types/topic_data.rs	74.25% <0.00%> (-0.30%)	⬇️
src/messages/submessages/nack_frag.rs	0.00% <0.00%> (ø)
src/dds/participant.rs	80.71% <0.00%> (+0.06%)	⬆️
src/network/udp_listener.rs	85.05% <0.00%> (+0.17%)	⬆️
src/dds/dp_event_loop.rs	86.32% <0.00%> (+0.28%)	⬆️
src/dds/writer.rs	43.40% <0.00%> (+0.47%)	⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[danieleades]

as you can see, this clippy action adds inline comments on the diff itself.

It can be configured to filter to only show errors that impact lines that were changed as part of the PR (in fact that's the default behaviour). The reason I've opted not to do this, is that prevents clippy from displaying 'non-local' errors. Ie, if you make a code change in place that causes a lint to fire somewhere else in the codebase, that would not be displayed on the PR with the default config.

[danieleades]

also, this job (and all the others) are failing due to koute/speedy#34