Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Solution must be recomputed if convergence has not been achieved in the last simulation time #4

Open
jhabriel opened this issue Mar 3, 2022 · 0 comments
Open

BUG: Solution must be recomputed if convergence has not been achieved in the last simulation time #4

jhabriel opened this issue Mar 3, 2022 · 0 comments
Assignees
@jhabriel
Labels
bug Something isn't working priority:low This issue represents a low priority wontfix This will not be worked on

Comments

@jhabriel
Copy link
Owner

jhabriel commented Mar 3, 2022

Currently, if t = sim_time and the solution did not convergence (this can be because we have not satisfied the tolerance, or we found negative volume), the simulation ends, rather than be recomputed.

Check if this is related with the time loop (user-side) or a bug in the time-stepping scheme from the core of PorePy.
@jhabriel jhabriel added bug Something isn't working todo This will get done eventually labels Mar 3, 2022
@jhabriel jhabriel self-assigned this Mar 3, 2022
@jhabriel jhabriel added the priority:medium This issue represents a medium priority label Mar 4, 2022
@jhabriel jhabriel added wontfix This will not be worked on priority:low This issue represents a low priority and removed priority:medium This issue represents a medium priority todo This will get done eventually labels Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhabriel jhabriel

Labels
bug Something isn't working priority:low This issue represents a low priority wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhabriel