Normalise title casing #2447
Merged
Normalise title casing #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaals
reviewed
Sep 12, 2024
| "optionOneWeekLabel": "One Week" | ||
| "optionOneHourLabel": "One hour", | ||
| "optionOneDayLabel": "One day", | ||
| "optionOneWeekLabel": "One week" | ||
| }, | ||
| "features": { |
There was a problem hiding this comment.
It might be cleaner to keep title casing on the feature titles.
There was a problem hiding this comment.
Title casing on the features and sentence casing everywhere else? It looks weird when casings are mixed. Like when a codebase doesn't follow a consistent style.
Co-authored-by: Johan Haals <[email protected]>
|
I agree, let's go with this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the title casing wasn't consistent and I normalised it to sentence casing since it seemed to be the most used style. Could also normalise to title case if that's preferred.