Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New integration #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DufourVictor
Copy link

I'm bored during this confinement so I propose a new graphic identity to Elephpant.me

I couldn't find where the "verify.blade.php" template was used so I didn't style it. If used tell me how I can access it and I will style this.

Hope you like this MR and I'm happy to be able to contribute as much as I can to this project.
If you have any questions don't hesitate.

@jgrossi
Copy link
Owner

jgrossi commented Nov 11, 2020

hey man! thanks so much for the contribution. gonna pull to my local and check the changes 🙏

@DufourVictor
Copy link
Author

DufourVictor commented Nov 12, 2020

Hope that you'll like it 😃

@jgrossi
Copy link
Owner

jgrossi commented Nov 17, 2020

hey man! first of all, thank you! amazing work!!! we have some comments (some of them we need to fix I think):

  • the table rows (gray background) is not 100% readable, so maybe it's a good idea to have a lighter bg to improve readability. can you change that please?
  • the logo @IgorSantos17 suggested to add the ".me" to the end, so it would be "ElePHPant.me";
  • when we change (+ or - buttons) the number of elephpants in the herd we use the markup to update the total (in the stimulus js controller I think). it seems after changing the styles that's broken. that's something for sure we can fix, np

I'm gonna try to push a commit to your branch with the stimulus js change (for the total in the herd). sounds good?

and one more time! thank you!

@DufourVictor
Copy link
Author

Hey! No problem, I really like this project and I'm very happy to contribute. Thanks to you for this project.

For your comments, I've fixed everything in a second commit.
Indeed I didn't notice for the total of elephpants in the herd. It's now fixed.

Tell me if I forgot something or if you want other changes.

@DufourVictor
Copy link
Author

DufourVictor commented Dec 17, 2020

Some news? 🙂
(Sorry I closed the MR unwittingly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants