inlines: make this.matches a dense rather than sparse array. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
This yields a significant performance boost. See #13. Of course, the speedup depends on the input. This will mostly affect texts with significant strings of inlines (longer paragraphs rather than just a few words). But on those, we are more than twice as fast with this change. Here are some inline-heavy benchmarks for comparison: This branch: parse inline-em-flat.dj x 24,362 ops/sec ±0.26% (95 runs sampled) parse lorem1.dj x 13,244 ops/sec ±0.29% (101 runs sampled) parse inline-em-nested.dj x 25,121 ops/sec ±0.23% (96 runs sampled) parse inline-em-worst.dj x 27,437 ops/sec ±0.66% (92 runs sampled) parse readme.dj x 2,529 ops/sec ±0.55% (96 runs sampled) Current main: parse inline-em-flat.dj x 25,057 ops/sec ±0.26% (99 runs sampled) parse lorem1.dj x 5,846 ops/sec ±0.26% (98 runs sampled) parse inline-em-nested.dj x 25,584 ops/sec ±0.26% (100 runs sampled) parse inline-em-worst.dj x 26,859 ops/sec ±0.29% (98 runs sampled) parse readme.dj x 1,144 ops/sec ±0.43% (96 runs sampled) Thanks to @matklad for identifying this as a bottleneck and suggesting the general direction of the improvement.
|
OK, this seems to work well now. I'm getting > 2X speedup in the most favorable benchmarks! |
|
On a real-world case parsing goes from 55ms too 40ms. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yields a 10-15% speeed boost in my tests. See #13.
However, we now fail a couple of smart quote tests. I need to look into that.