Define precise type for Event.annot
#101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next commit I introduce a precise union type for `Event.annot` and I want to avoid having to specify `as` type assertions.
This enables API users to identify the events returned by `parseEvents` in a type-safe manner.
This makes the Event type easier to work with.
not-my-profile
force-pushed
the
annot-type
branch
from
3853a52 to
f3ef4d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables API users to identify the events returned by
parseEventsin a type-safe manner.Note that the last commit which stops the encoding of the list styles into
annotdoes constitute a breaking change.