qs1dsearch: free object in _destroy #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
- Coverage 85.10% 85.09% -0.01%
==========================================
Files 367 367
Lines 27280 27281 +1
==========================================
- Hits 23216 23215 -1
- Misses 4064 4066 +2
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
|
Thanks for this! I have a pipeline (for gitlab.com) that runs valgrind to find memory leaks like the one you found; however it was taking way too long to execute so I effectively removed it. I should probably reinstate at least some version of it, and on GitHub.com. |
|
also #ProgrammingInC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.