This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
(semver-minor) define/export error constants #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defining and exporting constants to define various error messages makes them easier and more reliable to compare and test
1 task
| var ERROR_NO_COOKIE_PARSER = 'cookieParser is required use require(\'cookie-parser\'), connect.cookieParser or express.cookieParser'; | ||
| var ERROR_NO_SESSION = 'No session found'; | ||
| var ERROR_PASSPORT_NOT_INITIALIZED = 'Passport was not initialized'; | ||
| var ERROR_SESSION_STORE = 'Error in session store:\n'; |
There was a problem hiding this comment.
The \n should probably not be in the constant.. I'll move it to the message concatenaed to it on line 79.
|
I'd rather use the constant names you used as error codes? |
|
Something like function PassportSocketIoError (code) {
this.message = code
}
PassportSocketIoError.prototype = new Error();
var ERROR_NO_SESSION = 'No session found';
// during authorization
return auth.fail(data, new PassportSocketIoError(ERROR_NO_SESSION), false, accept);...? |
* Created PassportSocketIoError class that extends Error prototypally * replace `new Error(/* ... */)` with `new PassportSocketIoError(/* ... */)` * Add ERR_* messages to PassportSocketIoError.prorotype * export PassportSocketIoError class
Is this more to your liking? var ERROR_USER_NOT_AUTHORIZED = 'ERROR_USER_NOT_AUTHORIZED';
var ERROR_USER_NOT_FOUND = 'ERROR_USER_NOT_FOUND'; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defining and exporting constants to define various error messages
makes them easier and more reliable to compare and test