Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - OIDC with self-signed certificates guidance #242

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

austinfrog
Copy link
Contributor

@austinfrog austinfrog commented Jan 2, 2025

…OIDC

Artifactory uses the GitHub Actions' built-in HTTP client to download the JFrog CLI and perform authentication with JFrog Access for OpenID Connect (OIDC).

When an Artifactory instance is using self-signed certificates, you may run into the following error when exchanging token with OIDC:

Error: Exchanging JSON web token with an access token failed: self-signed certificate in certificate chain

This error occur can occur when trying to exchange a token for OIDC.

To resolve this we need to add the certificates to the NODE_EXTRA_CA_CERTS environmental variable.

  • Added a section explaining the use of self-signed certificates with OIDC/Github actions.

  • Provided guidance on how to configure self-signed certificates in the context of OIDC.

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

  • I used npm run format for formatting the code before submitting the pull request.


…OIDC

Artifactory uses the GitHub Actions' built-in HTTP client to download the JFrog CLI and perform authentication with JFrog Access for OpenID Connect (OIDC). 

When an Artifactory instance is using self-signed certificates, you may run into the following error: 

Error: Exchanging JSON web token with an access token failed: self-signed certificate in certificate chain

This error occur can occur when trying to download the jfrog cli or exchange a token for OIDC.

To resolve this we need to add the certificates to the NODE_EXTRA_CA_CERTS environmental variable.

- Added a section explaining the use of self-signed certificates with OIDC/Github actions.
- Provided guidance on how to configure self-signed certificates in the context of OIDC.
Copy link

github-actions bot commented Jan 2, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@austinfrog
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@EyalDelarea EyalDelarea changed the title Update README.md to include self-signed certificates information for … Update README.md - OIDC with self-signed certificates guidance Jan 7, 2025
@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Jan 7, 2025
@EyalDelarea EyalDelarea merged commit 812206b into jfrog:master Jan 7, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants