Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server configuration improvements #227

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Nov 19, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Note:

  • The internal setup-jfrog-cli-server server ID will no longer be available. Set a custom server ID if you need to reference the server directly.

New Feature:

  • Support custom server ID

Improvements:

  • Unique default server ID for each run of a workflow
  • Support multiple configurations

Bug fix:

@RobiNino RobiNino added the improvement Automatically generated release notes label Nov 19, 2024
@sverdlov93
Copy link
Contributor

Unique default server ID for each run of a workflow

breaking change? if someone used the old one?

@RobiNino
Copy link
Contributor Author

The pervious server ID was never documented, using it directly was as using an internal code. I can add the breaking change label if you think it necessary but I'm not sure this actually counts as one.

@sverdlov93
Copy link
Contributor

The pervious server ID was never documented, using it directly was as using an internal code. I can add the breaking change label if you think it necessary but I'm not sure this actually counts as one.

https://github.com/search?q=%22setup-jfrog-cli-server%22+language%3AYAML&type=code&l=YAML

@RobiNino RobiNino added breaking change Automatically generated release notes and removed breaking change Automatically generated release notes labels Nov 26, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Dec 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 4, 2024
@RobiNino RobiNino merged commit da7423c into jfrog:master Dec 4, 2024
26 of 27 checks passed
@RobiNino RobiNino added bug Something isn't working new feature Automatically generated release notes labels Dec 4, 2024
@JackCoplandGranta
Copy link

The readme does explicitly mentions this server id (and is now presumably incorrect?):
image

@tgharold
Copy link

tgharold commented Dec 4, 2024

As a user, we consider this to be a breaking change and our workflows are failing because of it. We'd have been okay if you had provided a migration path (add the new input in 4.5, then remove the current default in 5.0).

@hazeltonl
Copy link

As a user, we consider this to be a breaking change and our workflows are failing because of it. We'd have been okay if you had provided a migration path (add the new input in 4.5, then remove the current default in 5.0).

This may be a good opportunity to look at my Pull Request? It would potentially address this scenario where users inherit breaking changes when only the minor version has been updated. I assume only JFrog employee are able to add reviewers to PRs @RobiNino @eyalbe4
#228

@aairey
Copy link

aairey commented Dec 6, 2024

Unique default server ID for each run of a workflow

breaking change? if someone used the old one?

BREAKING CHANGE indeed
Workflows started failing here.

@RobiNino
Copy link
Contributor Author

Hi all,
We sincerely apologize for the inconvenience caused by this error on our part.
We have just released extension version v4.5.1, which restores the default server ID while also providing the option to set a custom server ID.
Thank you for your understanding and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Automatically generated release notes new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting --url option is mandatory error for ping and upload commands
7 participants