-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server configuration improvements #227
Conversation
breaking change? if someone used the old one? |
The pervious server ID was never documented, using it directly was as using an internal code. I can add the breaking change label if you think it necessary but I'm not sure this actually counts as one. |
https://github.com/search?q=%22setup-jfrog-cli-server%22+language%3AYAML&type=code&l=YAML |
As a user, we consider this to be a breaking change and our workflows are failing because of it. We'd have been okay if you had provided a migration path (add the new input in 4.5, then remove the current default in 5.0). |
This may be a good opportunity to look at my Pull Request? It would potentially address this scenario where users inherit breaking changes when only the minor version has been updated. I assume only JFrog employee are able to add reviewers to PRs @RobiNino @eyalbe4 |
BREAKING CHANGE indeed |
Hi all, |
npm run format
for formatting the code before submitting the pull request.Note:
setup-jfrog-cli-server
server ID will no longer be available. Set a custom server ID if you need to reference the server directly.New Feature:
Improvements:
Bug fix: