Fix rbc command to accept project with no spec #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
requested changes
Feb 25, 2025
lifecycle/cli.go
Outdated
| @@ -222,7 +222,7 @@ func getReleaseBundleCreationSpec(c *cli.Context) (*spec.SpecFiles, error) { | |||
| buildNumber := getStringFlagOrEnv(c, cliutils.BuildNumber, coreutils.BuildNumber) | |||
|
|
|||
| if buildName != "" && buildNumber != "" { | |||
| return speccore.CreateSpecFromBuildNameAndNumber(buildName, buildNumber) | |||
| return speccore.CreateSpecFromBuildNameAndNumber(buildName, buildNumber, cliutils.GetProject(c)) | |||
There was a problem hiding this comment.
Great!
Let's just add e2e tests to verify the release bundle is being created at the right project
There was a problem hiding this comment.
added new test TestCreateBundleWithoutSpecAndWithProject
bhanurp
changed the title
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Depends On
jfrog/jfrog-cli-core#1356
Fixes #2874