Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate artifactory commands #2828

Merged
merged 9 commits into from
Jan 30, 2025
Merged

Migrate artifactory commands #2828

merged 9 commits into from
Jan 30, 2025

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Jan 13, 2025 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends on:
jfrog/jfrog-cli-core#1334
jfrog/jfrog-cli-artifactory#34
jfrog/jfrog-cli-security#293

@bhanurp bhanurp changed the title Migrate artifactory commands WIP: Migrate artifactory commands Jan 13, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@bhanurp bhanurp force-pushed the migrate-artifactory-commands branch from 6dc2b78 to 13dc47e Compare January 23, 2025 06:20
@bhanurp bhanurp changed the title WIP: Migrate artifactory commands Migrate artifactory commands Jan 23, 2025
@EyalDelarea EyalDelarea added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Jan 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 23, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 23, 2025
EyalDelarea
EyalDelarea requested changes Jan 23, 2025
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@bhanurp bhanurp requested a review from EyalDelarea January 23, 2025 07:58
EyalDelarea
EyalDelarea approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhanurp bhanurp changed the base branch from migrate-artifactory-commands to dev January 28, 2025 06:11
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 30, 2025
EyalDelarea
EyalDelarea requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i would just not update the go version for now to avoid complications

go.mod Outdated Show resolved Hide resolved
@bhanurp bhanurp requested a review from EyalDelarea January 30, 2025 10:19
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Jan 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@EyalDelarea EyalDelarea merged commit 6cc1bf1 into jfrog:dev Jan 30, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino Awaiting requested review from RobiNino

@itsmeleela itsmeleela Awaiting requested review from itsmeleela

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhanurp @EyalDelarea