Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #2801

Merged
merged 16 commits into from
Dec 30, 2024
Merged

Fix tests #2801

merged 16 commits into from
Dec 30, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 25, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix broken CLI tests:

  • Python -> Update the expected dependency version
  • NuGet -> Fix failing action by installing .NET before NuGet to avoid installation issues.
    The action on ubuntu failed to start with permissions error, installing .NET before, should fix this issue.
  • Scripts Tests -> Update the oldest version of macOs from 12 to 13, as 12 is deprecated.
  • Transfer Tests -> Artifactory 6 setup failed due update of the base ubuntu image.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Dec 25, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review December 29, 2024 12:41
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
pip_test.go Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 29, 2024
Co-authored-by: Michael Sverdlov <[email protected]>
@EyalDelarea EyalDelarea merged commit ca7c705 into jfrog:dev Dec 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants