Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive scan integration test #2416

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Recursive scan integration test #2416

merged 8 commits into from
Jan 16, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 14, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

added an integration test to test recursive scan on multi-project directory
depends on: jfrog/jfrog-cli-core#1105

@eranturgeman eranturgeman changed the title added an integration test to test recursive scan over a directory wit… Recursive scan integration test Jan 14, 2024
@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jan 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@eranturgeman eranturgeman requested a review from attiasas January 15, 2024 07:36
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into recursi…
1840d47 
…ve-scan-integration-test

# Conflicts:
#	build/bump-version.sh
attiasas
attiasas reviewed Jan 15, 2024
View reviewed changes
xray_test.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@eranturgeman eranturgeman requested a review from attiasas January 15, 2024 10:29
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit b1416e8 into jfrog:dev Jan 16, 2024
60 of 63 checks passed
@eyalbe4 eyalbe4 added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eranturgeman @attiasas @eyalbe4