Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifactory resolution tests #2347

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Artifactory resolution tests #2347

merged 8 commits into from
Dec 11, 2023

Conversation

eranturgeman
Copy link
Collaborator

@eranturgeman eranturgeman commented Dec 7, 2023 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

This PR add integration tests for Xray to check dependencies resolution from an Artifactory server.
The added test checks 3 package managers: Npm, Yarn, NuGet

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@eranturgeman eranturgeman requested a review from yahavi December 7, 2023 11:45
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 7, 2023
yahavi
yahavi requested changes Dec 7, 2023
View reviewed changes
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 11, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit cee0ba4 into jfrog:dev Dec 11, 2023
@eranturgeman eranturgeman mentioned this pull request Dec 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @yahavi