-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config profile with repo API implementation #261
Merged
eranturgeman
merged 22 commits into
jfrog:dev
from
eranturgeman:config-profile-with-repo-api-integration
Dec 22, 2024
Merged
Config profile with repo API implementation #261
eranturgeman
merged 22 commits into
jfrog:dev
from
eranturgeman:config-profile-with-repo-api-integration
Dec 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e -> GetConfigProfileByUrl
eranturgeman
had a problem deploying
to
frogbot
December 10, 2024 07:56 — with
GitHub Actions
Failure
eranturgeman
changed the title
Config profile with repo API integration
Config profile with repo API implementation
Dec 10, 2024
eranturgeman
had a problem deploying
to
frogbot
December 10, 2024 14:33 — with
GitHub Actions
Failure
eranturgeman
added
ignore for release
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Dec 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 10, 2024
eranturgeman
had a problem deploying
to
frogbot
December 11, 2024 11:55 — with
GitHub Actions
Failure
eranturgeman
had a problem deploying
to
frogbot
December 11, 2024 12:22 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 11, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 11, 2024
…profile_repos (will not include repository info) + update GetConfigProfileByUrl signature
… inside the function
eranturgeman
had a problem deploying
to
frogbot
December 15, 2024 12:27 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 15, 2024
eranturgeman
had a problem deploying
to
frogbot
December 15, 2024 12:31 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 15, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 15, 2024
4 tasks
…o config-profile-with-repo-api-integration
eranturgeman
had a problem deploying
to
frogbot
December 17, 2024 16:44 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 17, 2024
…o config-profile-with-repo-api-integration
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 18, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 18, 2024
attiasas
requested changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checkout my comments
…o config-profile-with-repo-api-integration
…o config-profile-with-repo-api-integration
eranturgeman
had a problem deploying
to
frogbot
December 22, 2024 08:04 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 22, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 22, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Dec 22, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Dec 22, 2024
attiasas
approved these changes
Dec 22, 2024
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This Pr introduces new functionality: Get config profile by Url.
The old GetConfigProfile functionality was given a new name: GetConfigProfileByName
depends on: jfrog/jfrog-client-go#1057