Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config profile with repo API implementation #261

Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Dec 10, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This Pr introduces new functionality: Get config profile by Url.
The old GetConfigProfile functionality was given a new name: GetConfigProfileByName

depends on: jfrog/jfrog-client-go#1057

@eranturgeman eranturgeman changed the title Config profile with repo API integration Config profile with repo API implementation Dec 10, 2024
@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 11, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 15, 2024
…o config-profile-with-repo-api-integration
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 17, 2024
…o config-profile-with-repo-api-integration
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 18, 2024
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout my comments

utils/xsc/configprofile.go Outdated Show resolved Hide resolved
utils/validations/test_mocks.go Outdated Show resolved Hide resolved
utils/xsc/configprofile_test.go Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 22, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Dec 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 22, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/utils/validations 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/xsc 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/utils/validations/test_mocks.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/xsc/configprofile.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/utils/xsc/configprofile_test.go

@eranturgeman eranturgeman merged commit d0f1598 into jfrog:dev Dec 22, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants