Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker - Skip build-info if there are no image layers in Artifactory #722

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Docker - Skip build-info if there are no image layers in Artifactory #722

merged 3 commits into from
Mar 28, 2023

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Mar 27, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The build-info collection may fail if some or all of the image is not found in Artifactory after the image was pulled.
Clients may end up pulling images from their local cache rather than downloading them from Artifactory.

@Or-Geva Or-Geva requested a review from yahavi March 27, 2023 08:47
@Or-Geva Or-Geva added the bug Something isn't working label Mar 27, 2023
yahavi
yahavi requested changes Mar 27, 2023
View reviewed changes
artifactory/utils/container/buildinfo.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo_test.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo_test.go Outdated Show resolved Hide resolved
artifactory/utils/container/buildinfo_test.go Outdated Show resolved Hide resolved
@Or-Geva Or-Geva temporarily deployed to frogbot March 28, 2023 06:23 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@Or-Geva Or-Geva merged commit d45734b into jfrog:dev Mar 28, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Mar 30, 2023
Merged
@s-geiger-si
Copy link

Not sure if its related but I stumbled over this issue when I was investigating the cause for #804, so I thought I would mention it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Or-Geva @s-geiger-si @yahavi