Generify git log parsing #1337

RobiNino · 2025-01-21T10:34:48Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
This pull request is on the dev branch.
I used gofmt for formatting the code before submitting the pull request.

EyalDelarea

LGTM
Just see my comment :)

EyalDelarea · 2025-01-28T13:36:17Z

artifactory/commands/buildinfo/addgit.go

 	log.Info("Collecting build issues from VCS...")

-	// Check that git exists in path.
-	_, err := exec.LookPath("git")


I know we call this function after .git lookup has occurred, but is there any case where someone might call it without initializing it first?

RobiNino added the improvement Automatically generated release notes label Jan 21, 2025

RobiNino requested review from eyalbe4 and EyalDelarea January 21, 2025 10:34

RobiNino requested a deployment to frogbot January 21, 2025 10:34 — with GitHub Actions Waiting

RobiNino requested a deployment to frogbot January 23, 2025 10:48 — with GitHub Actions Waiting

Generify git log parsing

91541a8

RobiNino force-pushed the generic-git-log branch from 282e93d to 91541a8 Compare January 26, 2025 19:20

RobiNino requested a deployment to frogbot January 26, 2025 19:20 — with GitHub Actions Waiting

EyalDelarea approved these changes Jan 28, 2025

View reviewed changes

Add a plain go log api

f77413c

RobiNino requested a deployment to frogbot January 28, 2025 19:41 — with GitHub Actions Waiting

RobiNino closed this Feb 3, 2025

Provide feedback