Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Fix files count and size after stop #1013

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 31, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Dependency for jfrog/jfrog-cli#2290

The accuracy of the progress bar decreases if the jf rt transfer-files is stopped in the middle. When running jf rt transfer-files for the second time, we only retrieve directories marked as 'completed' from the snapshot manager. However, in the TransferRunStatus, we still have information about the last operation, which includes files transferred in a directory that wasn't finished.

@yahavi yahavi self-assigned this Oct 31, 2023
@yahavi yahavi added the bug Something isn't working label Oct 31, 2023
@yahavi yahavi force-pushed the transfer-files-count branch from c5c2335 to 06c103a Compare October 31, 2023 16:03
@yahavi yahavi temporarily deployed to frogbot October 31, 2023 16:03 — with GitHub Actions Inactive
@yahavi yahavi force-pushed the transfer-files-count branch from 06c103a to a36eab5 Compare November 2, 2023 14:57
@yahavi yahavi marked this pull request as ready for review November 2, 2023 14:57
@yahavi yahavi requested a review from eyalbe4 November 2, 2023 14:57
Copy link
Contributor

github-actions bot commented Nov 2, 2023


@yahavi yahavi merged commit 13b1588 into jfrog:dev Nov 5, 2023
@yahavi yahavi deleted the transfer-files-count branch November 5, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants