Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamerep #6

Merged
merged 55 commits into from
Nov 10, 2024
Merged

Gamerep #6

merged 55 commits into from
Nov 10, 2024

Conversation

jfredett
Copy link
Owner

@jfredett jfredett commented Nov 1, 2024

Work proceedeth 'pon the representation of the game, this is that work. I like seeing the numbers in the top right showing how much code I get to delete.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 93.02899% with 113 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (8106a80) to head (2ebcdcd).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
src/game/action/game.rs 0.00% 21 Missing ⚠️
src/types/log/mod.rs 83.13% 14 Missing ⚠️
src/notation/fen/position_metadata.rs 95.06% 12 Missing ⚠️
src/game/action/chess.rs 0.00% 9 Missing ⚠️
src/board/interface/play.rs 0.00% 8 Missing ⚠️
src/types/log/write_head.rs 94.30% 7 Missing ⚠️
src/game/variation.rs 97.00% 6 Missing ⚠️
src/notation/square/mod.rs 93.82% 5 Missing ⚠️
src/engine/driver/hazel.rs 87.09% 4 Missing ⚠️
src/game/compiles_to.rs 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   91.36%   94.57%   +3.20%     
==========================================
  Files          64       67       +3     
  Lines        4716     5987    +1271     
==========================================
+ Hits         4309     5662    +1353     
+ Misses        407      325      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfredett jfredett force-pushed the gamerep branch 3 times, most recently from 363026a to 5e76c82 Compare November 2, 2024 21:58
Copy link

github-actions bot commented Nov 2, 2024

BUG=4
FIXME=21
HACK=1
NOTE=16
TODO=27
OQ=1

@jfredett jfredett force-pushed the gamerep branch 25 times, most recently from 0dc26ca to 4a5ffdd Compare November 8, 2024 20:11
issue was due to version discrepancy in `rg`, I think.
These were useful when I was working on the bitboard stuff to
make sure my implementations were correct in terms of expected speedups,
but I think I'd rather spend time rebuilding them later into a proper
suite that helps drive the ELO of hazel.

Something something premature optimization.
@jfredett jfredett merged commit 9c7e90a into main Nov 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants