Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the size from the Array signature. #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yanxke
Copy link

@yanxke yanxke commented Jan 3, 2024

Pull Request Details

Provide details about your pull request and what it adds, fixes, or changes.

Remove the size from the Array signature because the Python code can't parse this. Removing this makes it works like a Vector which can be parsed by the Python code. The API itself is ambiguous because it can't tell what should be after a starting '['

Breaking Changes

Describe what features are broken by this pull request and why, if any.

Signature on Array.

Issues Fixed

Enter the issue numbers resolved by this pull request below, if any.

None

Other Relevant Information

Provide any other important details below.

@jfjlaros
Copy link
Owner

jfjlaros commented Jan 3, 2024

This is a problem in the Python client, where working with arrays is not implemented yet. This is work in progress (for a while).

The size of the array must be communicated, otherwise the client cannot send an array because of its unknown size.

@yanxke
Copy link
Author

yanxke commented Jan 3, 2024

The array size is already sent prior to sending the data as in Vector. It seems to work just fine for me right now.

@jfjlaros
Copy link
Owner

jfjlaros commented Jan 3, 2024

The problem is client side, it should know the size of the array before sending anything.

As said, this is work in progress. For now you can safely assume that Array is not implemented.

@suahelen
Copy link

suahelen commented Feb 29, 2024

https://github.com/csem/arduino-simple-rpc/tree/feature/support_array_t-s

here an implementation on client side that would resolve it.
a small change on the mcu side would be necessary. The signature of an array should be changed to '[#]'

It is based on jfjlaros/arduino-simple-rpc#26 that would allow np array writes.

@jfjlaros jfjlaros force-pushed the master branch 2 times, most recently from bdf5cf6 to 07e9b99 Compare October 19, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants