Use typed-process
#287
Open
Use typed-process
#287
+147
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
typed-process-error-message
branch
3 times, most recently
from
19d9161 to
0c524a0
Compare
9999years
force-pushed
the
typed-process-error-message
branch
from
0c524a0 to
31afb68
Compare
|
This also fixes a failure I've encountered when the thread running tmp-postgres is killed. I use something like this https://github.com/eldr-io/hastl/blob/main/src/DevelMain.hs to run a development environment. When the thread running tmp-postgres is killed, ghcid crashes. I narrowed this down to I haven't fully figured out why yet, but I +1 this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vastly improves error messages by using
typed-processinstead ofprocess.This is largely another take on #253, except it improves the error messages for many more errors.