Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve load times w/ fixed gemset iteration #87

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Feb 4, 2018

  1. Configuration menu
    Copy the full SHA
    5a1b480 View commit details
    Browse the repository at this point in the history
  2. which hook working for no gemset and gemsets passed as env var

    New version adds ~15ms to `ruby -e 'puts "yo"' time :)
    
    Quite possibly broken for more complex cases, but it's a start.
    
    Also, I renamed the hooks to have their event name ('which', 'exec',
    'rehash') in their filename so they're easier to pick out in
    `RBENV_DEBUG=1` output.
    nrser committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    5a382ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f33dec4 View commit details
    Browse the repository at this point in the history
  4. Update the exec hook to use the fast approach

    Where we're at:
    
        $ time ruby -e 'puts "yo"'
        yo
    
        real	0m0.173s
        user	0m0.097s
        sys	0m0.034s
    
    Versus with all rbenv-gemset hooks removed:
    
        $ time ruby -e 'puts "yo"'
        yo
    
        real	0m0.135s
        user	0m0.078s
        sys	0m0.025s
    
    So added ~40ms with the hooks (rehash isn't used in that run). Not bad.
    nrser committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    8dbc6f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. More comments / documentation

    nrser committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    78a17e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. Configuration menu
    Copy the full SHA
    bad7a92 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. Configuration menu
    Copy the full SHA
    e8fb016 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Don't export RBENV_GEMSET_EXEC_ALREADY

    While I'm sure it was there for a reason - I recall
    there being weird and troublesome double
    executions going on when I dug into the
    rbenv-gemset stuff - it messes up subprocesses
    that run one lock exe invoked from inside
    another.
    nrser committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    43ca1c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. add shebangs

    AprilArcus committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    1835c77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f303f6 View commit details
    Browse the repository at this point in the history