-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve load times w/ fixed gemset iteration #87
Open
AprilArcus
wants to merge
10
commits into
jf:master
Choose a base branch
from
AprilArcus:fix-gemset-iteration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5a1b480 - Browse repository at this point
Copy the full SHA 5a1b480View commit details -
which
hook working for no gemset and gemsets passed as env varNew version adds ~15ms to `ruby -e 'puts "yo"' time :) Quite possibly broken for more complex cases, but it's a start. Also, I renamed the hooks to have their event name ('which', 'exec', 'rehash') in their filename so they're easier to pick out in `RBENV_DEBUG=1` output.
Configuration menu - View commit details
-
Copy full SHA for 5a382ef - Browse repository at this point
Copy the full SHA 5a382efView commit details -
Configuration menu - View commit details
-
Copy full SHA for f33dec4 - Browse repository at this point
Copy the full SHA f33dec4View commit details -
Update the exec hook to use the fast approach
Where we're at: $ time ruby -e 'puts "yo"' yo real 0m0.173s user 0m0.097s sys 0m0.034s Versus with all rbenv-gemset hooks removed: $ time ruby -e 'puts "yo"' yo real 0m0.135s user 0m0.078s sys 0m0.025s So added ~40ms with the hooks (rehash isn't used in that run). Not bad.
Configuration menu - View commit details
-
Copy full SHA for 8dbc6f1 - Browse repository at this point
Copy the full SHA 8dbc6f1View commit details
Commits on Feb 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 78a17e0 - Browse repository at this point
Copy the full SHA 78a17e0View commit details
Commits on Feb 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bad7a92 - Browse repository at this point
Copy the full SHA bad7a92View commit details
Commits on Sep 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e8fb016 - Browse repository at this point
Copy the full SHA e8fb016View commit details
Commits on Oct 8, 2018
-
Don't export RBENV_GEMSET_EXEC_ALREADY
While I'm sure it was there for a reason - I recall there being weird and troublesome double executions going on when I dug into the rbenv-gemset stuff - it messes up subprocesses that run one lock exe invoked from inside another.
Configuration menu - View commit details
-
Copy full SHA for 43ca1c1 - Browse repository at this point
Copy the full SHA 43ca1c1View commit details
Commits on Dec 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1835c77 - Browse repository at this point
Copy the full SHA 1835c77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f303f6 - Browse repository at this point
Copy the full SHA 5f303f6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.