Feature/rabbitmq adapters #87
Conversation
…rsistence.RabbitMq.
|
I can see more than 18 code warnings in this PR, can you do what it takes to remove the warnings? We see those in Rider, but you may not see them in VS which is a problem I need to solve. To get VS to use the same formatting rules. Perhaps I need to format your code (In Rider) once it is all in shape, but then I would need permission to edit the PR, which I dont think I have right now in your repo? |
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> |
There was a problem hiding this comment.
You should not define nor here, as they are controlled centrally in Directory.Build.props at the root of the repo
| <value>Message cannot be empty</value> | ||
| </data> | ||
| <data name="ValidationExtensions_InvalidStorageAccountResourceName" xml:space="preserve"> | ||
| <value>The Azure Storage Table/Blob/Queue name: '{0}' contains illegal characters or is not the correct length</value> |
There was a problem hiding this comment.
Should this message be reworded? and are you sure the name is correct? Is StorageAccount a thing in the RabbitMq world?
|
|
||
| public const string RabbitMqExchangeNameValidationExpression = @"^[a-z0-9_\.\-\/]{1,255}$"; | ||
|
|
||
| public const string StorageAccountResourceNameValidationExpression = @"^[a-z0-9\-]{3,63}$"; |
| useAsyncDispatcher); | ||
| return options.ToConnectionString(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is all this dead code? can we remove it all?
| internal const string PasswordSettingName = "ApplicationServices:Persistence:RabbitMQ:Password"; | ||
| internal const string VirtualHostSettingName = "ApplicationServices:Persistence:RabbitMQ:VirtualHost"; | ||
|
|
||
| public RabbitMqStoreOptions( |
There was a problem hiding this comment.
Can this be private, to stop consumers using it directly, and force them to use the From* methods below?
| using RabbitMQ.Client; | ||
|
|
||
| namespace Infrastructure.Persistence.RabbitMq.ApplicationServices | ||
| { |
There was a problem hiding this comment.
We prefer using namespaces without blocks
|
|
||
| public override bool Equals(object? obj) | ||
| { | ||
| if (obj is not TopicExistence other) |
There was a problem hiding this comment.
Code formatting rules should wrap the if statement in braces.
| @@ -0,0 +1,12 @@ | |||
| namespace Infrastructure.Persistence.Shared.IntegrationTests.RabbitMq; | |||
|
|
|||
| public static class RabbitMqBase | |||
| _emulator.StartAsync().GetAwaiter().GetResult(); | ||
|
|
||
| var connectionString = _emulator.GetConnectionString(); | ||
| var managementUri = _emulator.GetManagementUri(); |
| .WithPortBinding(15672, assignRandomHostPort: true) | ||
| .WithEnvironment("RABBITMQ_DEFAULT_USER", "guest") | ||
| .WithEnvironment("RABBITMQ_DEFAULT_PASS", "guest") | ||
| .WithWaitStrategy(Wait.ForUnixContainer().UntilPortIsAvailable(5672)) |
There was a problem hiding this comment.
can this port be moved to a constant at top of this file?
Implement specific technology adapters for RabbitMQ in a new assembly.