-
Notifications
You must be signed in to change notification settings - Fork 7
Reviewing Pull Requests
Jezz Santos edited this page Mar 9, 2017
·
2 revisions
Just a quick cheat-sheet for reference.
Someone submits a PR, you want to view it in the dev environment.
Step 1: create a new branch on your desktop, and pull the PR from their repo
We need to know: (a) what repo the PR is from, and (b) what branch are they on.
In tortoise git:
- Create a new branch called: "username-branchname" (i.e. bobby-master)
- Pull, with arbitrary URL to be: https://github.com/bobby/.git, using the remote branch name of their repo: i.e. branchname
Step 2: Do whatever commits you like. Use messages they are going to read.
Step 3: Push commits to PR
- Push, from Local: "username-branch", to Remote branch: "branchname", using Arbitrary URL: https://github.com/bobby/.git
If all goes well, my commits on their branch will appear in the PR on github.
Then comments can be made to the PR thread.