Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two fixes #94

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Two fixes #94

wants to merge 5 commits into from

Conversation

hugegreenbug
Copy link

Fixes the remote control pad from being 12 px above the main controls div in sass
Fixes the now playing title from being cut off in browsers other than crhome in sass

Fixes the title in the now playing box from being cut off in browsers other than chrome
Fixed title from being cut off in browsers other than firefox
Fixed remote pad from being 12px above the main-controls container div
Fix for the now playing title from being cut off in browsers other than chrome
@janhicken
Copy link

You changed the files located in the dist folder but these are generated by grunt and compass. I don't really understand why they are checked into the repository anyway.

On the next build, these changes are going to be overridden. In order to make changes to the style.css file, you have to look for the corresponding files in src/theme/**/*.scss. All these files are processed and concatenated into the styles.css using compass.

@hugegreenbug
Copy link
Author

I did both, I edited the sass and I checked in the built version. Sorry for
checking in the built version, but I did make the changes to the source.

Hugh

On Thu, Jan 15, 2015 at 3:06 AM, Jan [email protected] wrote:

You changed the files located in the dist folder but these are generated
by grunt and compass. I don't really understand why they are checked into
the repository anyway.

On the next build, these changes are going to be overridden. In order to
make changes to the style.css file, you have to look for the corresponding
files in src/theme/*/.scss. All these files are processed and
concatenated into the styles.css using compass.


Reply to this email directly or view it on GitHub
#94 (comment).

@janhicken
Copy link

Nevermind, I'm sorry, didn't recognize you edited them, too. It's just a bit confusing to have all changes listed twice in the commits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants