Skip to content

Port stale connection test to 12.1.x #13255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: jetty-12.1.x
Choose a base branch
from
Draft

Port stale connection test to 12.1.x #13255

wants to merge 2 commits into from

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 18, 2025

No description provided.

@gregw
Copy link
Contributor Author

gregw commented Jun 18, 2025

Fails mostly. Sometimes passes. Once I saw:

2025-06-19 08:42:24.594:INFO :oejh2.HTTP2Stream:client-73: Failure while notifying listener org.eclipse.jetty.http2.client.transport.internal.HttpChannelOverHTTP2$Listener@605f4313
java.lang.NullPointerException: Cannot invoke "org.eclipse.jetty.http2.HTTP2Channel$Client.onFailure(java.lang.Throwable, org.eclipse.jetty.util.Callback)" because "channel" is null
	at org.eclipse.jetty.http2.client.transport.internal.HttpChannelOverHTTP2$Listener.onFailure(HttpChannelOverHTTP2.java:239)
	at org.eclipse.jetty.http2.HTTP2Stream.notifyFailure(HTTP2Stream.java:937)
	at org.eclipse.jetty.http2.HTTP2Stream.onFailure(HTTP2Stream.java:639)
	at org.eclipse.jetty.http2.HTTP2Stream.process(HTTP2Stream.java:379)
	at org.eclipse.jetty.http2.HTTP2Session.failStream(HTTP2Session.java:731)
	at org.eclipse.jetty.http2.HTTP2Session.onFailure(HTTP2Session.java:696)
	at org.eclipse.jetty.http2.HTTP2Session.abort(HTTP2Session.java:683)
	at org.eclipse.jetty.http2.HTTP2Session$StreamsState.onWriteFailure(HTTP2Session.java:2286)
	at org.eclipse.jetty.http2.HTTP2Session.onWriteFailure(HTTP2Session.java:676)
	at org.eclipse.jetty.http2.internal.HTTP2Flusher.onFailure(HTTP2Flusher.java:401)
	at org.eclipse.jetty.util.ExceptionUtil.callAndThen(ExceptionUtil.java:422)
	at org.eclipse.jetty.util.IteratingCallback.doOnFailureOnCompleted(IteratingCallback.java:286)
	at org.eclipse.jetty.util.IteratingCallback.processing(IteratingCallback.java:512)
	at org.eclipse.jetty.util.IteratingCallback.iterate(IteratingCallback.java:354)
	at org.eclipse.jetty.http2.HTTP2Session$StreamsState.flush(HTTP2Session.java:2709)
	at org.eclipse.jetty.http2.HTTP2Session$StreamsState.createLocalStream(HTTP2Session.java:2506)
	at org.eclipse.jetty.http2.HTTP2Session$StreamsState.newLocalStream(HTTP2Session.java:2422)
	at org.eclipse.jetty.http2.HTTP2Session.newStream(HTTP2Session.java:747)
	at org.eclipse.jetty.http2.client.transport.internal.HttpSenderOverHTTP2.sendHeaders(HttpSenderOverHTTP2.java:126)
	at org.eclipse.jetty.client.transport.HttpSender$ContentSender.process(HttpSender.java:570)
	at org.eclipse.jetty.util.IteratingCallback.processing(IteratingCallback.java:377)
	at org.eclipse.jetty.util.IteratingCallback.iterate(IteratingCallback.java:354)
	at org.eclipse.jetty.client.transport.HttpSender.send(HttpSender.java:86)
	at org.eclipse.jetty.http2.client.transport.internal.HttpChannelOverHTTP2.send(HttpChannelOverHTTP2.java:114)
	at org.eclipse.jetty.client.transport.HttpChannel.send(HttpChannel.java:143)
	at org.eclipse.jetty.client.transport.HttpConnection.send(HttpConnection.java:113)
	at org.eclipse.jetty.http2.client.transport.internal.HttpConnectionOverHTTP2.send(HttpConnectionOverHTTP2.java:149)
	at org.eclipse.jetty.client.transport.HttpDestination.send(HttpDestination.java:432)
	at org.eclipse.jetty.client.transport.HttpDestination.process(HttpDestination.java:408)
	at org.eclipse.jetty.client.transport.HttpDestination.process(HttpDestination.java:363)
	at org.eclipse.jetty.client.transport.HttpDestination.send(HttpDestination.java:346)
	at org.eclipse.jetty.client.transport.HttpDestination.succeeded(HttpDestination.java:279)
	at org.eclipse.jetty.client.AbstractConnectionPool.proceed(AbstractConnectionPool.java:316)
	at org.eclipse.jetty.client.AbstractConnectionPool$FutureConnection.succeeded(AbstractConnectionPool.java:616)
	at org.eclipse.jetty.client.AbstractConnectionPool$FutureConnection.succeeded(AbstractConnectionPool.java:594)
	at org.eclipse.jetty.util.Promise$Wrapper.succeeded(Promise.java:186)
	at org.eclipse.jetty.http2.client.transport.internal.HTTPSessionListenerPromise.onServerPreface(HTTPSessionListenerPromise.java:89)
	at org.eclipse.jetty.http2.client.transport.internal.HTTPSessionListenerPromise.onSettings(HTTPSessionListenerPromise.java:72)
	at org.eclipse.jetty.http2.HTTP2Session.notifySettings(HTTP2Session.java:1324)
	at org.eclipse.jetty.http2.HTTP2Session.onSettings(HTTP2Session.java:449)
	at org.eclipse.jetty.http2.HTTP2Session.onSettings(HTTP2Session.java:434)
	at org.eclipse.jetty.http2.client.internal.HTTP2ClientSession.onSettings(HTTP2ClientSession.java:93)
	at org.eclipse.jetty.http2.HTTP2Connection.onSettings(HTTP2Connection.java:284)
	at org.eclipse.jetty.http2.parser.BodyParser.notifySettings(BodyParser.java:151)
	at org.eclipse.jetty.http2.parser.SettingsBodyParser.onSettings(SettingsBodyParser.java:225)
	at org.eclipse.jetty.http2.parser.SettingsBodyParser.onSettings(SettingsBodyParser.java:217)
	at org.eclipse.jetty.http2.parser.SettingsBodyParser.parse(SettingsBodyParser.java:151)
	at org.eclipse.jetty.http2.parser.SettingsBodyParser.parse(SettingsBodyParser.java:93)
	at org.eclipse.jetty.http2.parser.Parser.parseBody(Parser.java:230)
	at org.eclipse.jetty.http2.parser.Parser.parse(Parser.java:157)
	at org.eclipse.jetty.http2.HTTP2Connection$HTTP2Producer.produce(HTTP2Connection.java:378)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produceTask(AdaptiveExecutionStrategy.java:518)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:262)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.produce(AdaptiveExecutionStrategy.java:196)
	at org.eclipse.jetty.http2.HTTP2Connection.produce(HTTP2Connection.java:231)
	at org.eclipse.jetty.http2.HTTP2Connection.onFillable(HTTP2Connection.java:165)
	at org.eclipse.jetty.http2.HTTP2Connection$FillableCallback.succeeded(HTTP2Connection.java:567)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:99)
	at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:54)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:484)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:447)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:297)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.run(AdaptiveExecutionStrategy.java:202)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:312)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:999)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1229)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1184)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@gregw gregw mentioned this pull request Jun 19, 2025
Closed
@gregw
Copy link
Contributor Author

gregw commented Jun 19, 2025

@sbordet @lorban This test was failing because I was hitting max queued requests per destination.
I set that larger and this test is now good.

@lorban
Copy link
Contributor

lorban commented Jun 19, 2025

I cranked the requestCount up to 10k and the latch's await delay to 15s and the test fails.

Apparently, some requests are left pending in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregw @lorban