Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding error in MultiBufferFileMappedHttpContent that truncates the contents of files over 2 GB in size #12688

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jan 9, 2025

Fixes #12680

@lorban lorban added the Bug For general bugs on Jetty side label Jan 9, 2025
@lorban lorban requested a review from joakime January 9, 2025 10:29
@lorban lorban self-assigned this Jan 9, 2025
@joakime joakime linked an issue Jan 9, 2025 that may be closed by this pull request
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out to be a subtle math bug, cool.

@lorban lorban merged commit 8ec6283 into jetty-12.1.x Jan 9, 2025
2 of 4 checks passed
@lorban lorban deleted the fix/12.1.x/resourcehandler-over-2GB branch January 9, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

ResourceHandler cannot handle files over 2GB in size.
2 participants