Issue #10055 - fix core deploy with --dry-run #10056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
janbartel
reviewed
Jul 5, 2023
| @@ -693,7 +693,12 @@ else if (properties.size() > 0) | |||
| // TODO module path | |||
|
|
|||
| for (Prop property : environment.getProperties()) | |||
| cmd.addArg(property.key + "=" + property.value); | |||
| { | |||
| String value = property.value; | |||
There was a problem hiding this comment.
Can this ever be a genuine environment variable that should appear unquoted?
There was a problem hiding this comment.
I don't think so, as the environment should be the properties after expansion.
gregw
requested changes
Jul 7, 2023
Comment on lines
+698
to
+700
| if (isDryRun() && value != null && value.contains("$")) | ||
| value = "'" + value + "'"; | ||
| cmd.addArg(property.key + "=" + value); |
There was a problem hiding this comment.
This feels a bit arbitrary. What if the value contains space? what if the value contains ' or "? Isn't there a method already that checks if a string needs to be quoted and then quotes it correctly, perhaps escaping quote characters?
|
Replaced by #10090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10055
Use single quotes around property values containing
$for--dry-run.