Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment of static files does not work with --dry-run Jetty-12 #10055

Closed
lachlan-roberts opened this issue Jul 3, 2023 · 3 comments
Closed

Deployment of static files does not work with --dry-run Jetty-12 #10055

lachlan-roberts opened this issue Jul 3, 2023 · 3 comments
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12.0.x

Description
The output of dry run does not work when pasted into command line when using static content with core-deploy module.

How to reproduce?

java -jar $JETTY_HOME/start.jar --add-to-start=core-deploy,http
mkdir webapps/ROOT
echo "hello world" > webapps/ROOT/index.html
java -jar $JETTY_HOME/start.jar --dry-run
# paste the output of the dry run

Output of --dry-run:

/opt/java/jdk-17.0.6+10/bin/java -Djava.io.tmpdir=/tmp -Djetty.home=/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home -Djetty.base=/tmp/jetty-test --class-path /tmp/jetty-test/resources:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/logging/slf4j-api-2.0.7.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/logging/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-http-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-server-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-xml-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-util-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-io-12.0.0-SNAPSHOT.jar:/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/jetty-deploy-12.0.0-SNAPSHOT.jar org.eclipse.jetty.xml.XmlConfiguration 'java.version'='17.0.6' 'java.version.major'='17' 'java.version.micro'='6' 'java.version.minor'='0' 'java.version.platform'='17' 'jetty.base'='/tmp/jetty-test' 'jetty.base.uri'='file:///tmp/jetty-test' 'jetty.home'='/home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home' 'jetty.home.uri'='file:///home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home' 'jetty.webapp.addServerClasses'='org.eclipse.jetty.logging.,file:///home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/lib/logging/,org.slf4j.' 'runtime.feature.alpn'='true' 'slf4j.version'='2.0.7' /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty-bytebufferpool.xml /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty-threadpool.xml /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty.xml /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty-deploy.xml /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty-http.xml --env core contextHandlerClass=org.eclipse.jetty.server.handler.ResourceHandler$ResourceContext /home/lachlan/webtide/jetty-12.0.x/jetty-home/target/jetty-home/etc/jetty-core-deploy.xml

2023-07-03 10:32:26.866:INFO :oejs.Server:main: jetty-12.0.0-SNAPSHOT; built: 2023-07-03T00:21:06.345Z; git: ec2dbe73a8fb29243820ad822074808c422d056c; jvm 17.0.6+10
2023-07-03 10:32:26.888:INFO :oejdp.ScanningAppProvider:main: Deployment monitor core in [file:///tmp/jetty-test/webapps/] at intervals 0s
2023-07-03 10:32:26.895:INFO :oejd.DeploymentManager:main: addApp: App@654f0d9c[core,null,/tmp/jetty-test/webapps/ROOT]
2023-07-03 10:32:26.898:WARN :oejd.DeploymentManager:main: Unable to reach node goal: started
java.lang.NullPointerException: No Handler created for App: App@654f0d9c[core,null,/tmp/jetty-test/webapps/ROOT]
        at org.eclipse.jetty.deploy.bindings.StandardDeployer.processBinding(StandardDeployer.java:35)
        at org.eclipse.jetty.deploy.AppLifeCycle.runBindings(AppLifeCycle.java:183)
        at org.eclipse.jetty.deploy.DeploymentManager.requestAppGoal(DeploymentManager.java:525)
        at org.eclipse.jetty.deploy.DeploymentManager.addApp(DeploymentManager.java:165)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.pathAdded(ScanningAppProvider.java:289)
        at org.eclipse.jetty.deploy.providers.ContextProvider.pathAdded(ContextProvider.java:520)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider$1.pathAdded(ScanningAppProvider.java:67)
        at org.eclipse.jetty.util.Scanner.reportAddition(Scanner.java:842)
        at org.eclipse.jetty.util.Scanner.reportDifferences(Scanner.java:808)
        at org.eclipse.jetty.util.Scanner.scan(Scanner.java:715)
        at org.eclipse.jetty.util.Scanner.doStart(Scanner.java:603)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.doStart(ScanningAppProvider.java:260)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.DeploymentManager.startAppProvider(DeploymentManager.java:595)
        at org.eclipse.jetty.deploy.DeploymentManager.doStart(DeploymentManager.java:266)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.server.Server.start(Server.java:601)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:395)
        at org.eclipse.jetty.server.Server.doStart(Server.java:542)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1983)
2023-07-03 10:32:26.901:WARN :oejx.XmlConfiguration:main: Unable to execute XmlConfiguration
java.lang.NullPointerException: No Handler created for App: App@654f0d9c[core,null,/tmp/jetty-test/webapps/ROOT]
        at org.eclipse.jetty.deploy.bindings.StandardDeployer.processBinding(StandardDeployer.java:35)
        at org.eclipse.jetty.deploy.AppLifeCycle.runBindings(AppLifeCycle.java:183)
        at org.eclipse.jetty.deploy.DeploymentManager.requestAppGoal(DeploymentManager.java:525)
        at org.eclipse.jetty.deploy.DeploymentManager.addApp(DeploymentManager.java:165)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.pathAdded(ScanningAppProvider.java:289)
        at org.eclipse.jetty.deploy.providers.ContextProvider.pathAdded(ContextProvider.java:520)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider$1.pathAdded(ScanningAppProvider.java:67)
        at org.eclipse.jetty.util.Scanner.reportAddition(Scanner.java:842)
        at org.eclipse.jetty.util.Scanner.reportDifferences(Scanner.java:808)
        at org.eclipse.jetty.util.Scanner.scan(Scanner.java:715)
        at org.eclipse.jetty.util.Scanner.doStart(Scanner.java:603)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.doStart(ScanningAppProvider.java:260)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.DeploymentManager.startAppProvider(DeploymentManager.java:595)
        at org.eclipse.jetty.deploy.DeploymentManager.doStart(DeploymentManager.java:266)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.server.Server.start(Server.java:601)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:395)
        at org.eclipse.jetty.server.Server.doStart(Server.java:542)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1983)
Exception in thread "main" java.lang.NullPointerException: No Handler created for App: App@654f0d9c[core,null,/tmp/jetty-test/webapps/ROOT]
        at org.eclipse.jetty.deploy.bindings.StandardDeployer.processBinding(StandardDeployer.java:35)
        at org.eclipse.jetty.deploy.AppLifeCycle.runBindings(AppLifeCycle.java:183)
        at org.eclipse.jetty.deploy.DeploymentManager.requestAppGoal(DeploymentManager.java:525)
        at org.eclipse.jetty.deploy.DeploymentManager.addApp(DeploymentManager.java:165)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.pathAdded(ScanningAppProvider.java:289)
        at org.eclipse.jetty.deploy.providers.ContextProvider.pathAdded(ContextProvider.java:520)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider$1.pathAdded(ScanningAppProvider.java:67)
        at org.eclipse.jetty.util.Scanner.reportAddition(Scanner.java:842)
        at org.eclipse.jetty.util.Scanner.reportDifferences(Scanner.java:808)
        at org.eclipse.jetty.util.Scanner.scan(Scanner.java:715)
        at org.eclipse.jetty.util.Scanner.doStart(Scanner.java:603)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.doStart(ScanningAppProvider.java:260)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.DeploymentManager.startAppProvider(DeploymentManager.java:595)
        at org.eclipse.jetty.deploy.DeploymentManager.doStart(DeploymentManager.java:266)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.server.Server.start(Server.java:601)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:395)
        at org.eclipse.jetty.server.Server.doStart(Server.java:542)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1983)
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Jul 3, 2023
@lachlan-roberts lachlan-roberts changed the title Deployment of static files does not work with --dry-run Deployment of static files does not work with --dry-run Jetty-12 Jul 3, 2023
@lachlan-roberts
Copy link
Contributor Author

I think the issue is that in org.eclipse.jetty.server.handler.ResourceHandler$ResourceContext, the $ResourceContext is interpreted as an environment variable.

I have tested by quoting this with single quotes and it works.

lachlan-roberts added a commit that referenced this issue Jul 3, 2023
@lachlan-roberts
Issue #10055 - fix core deploy with --dry-run
7a23f55 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Jul 3, 2023
Closed
@lachlan-roberts lachlan-roberts self-assigned this Jul 3, 2023
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.0.beta4 Jul 11, 2023
@gregw
Copy link
Contributor

gregw commented Jul 12, 2023

will be fixed by #10090

@gregw gregw moved this from 🏗 In progress to 👀 In review in Jetty 12.0.0.beta4 Jul 12, 2023
@gregw gregw linked a pull request Jul 12, 2023 that will close this issue
Improved start.jar dry-run command line quoting #10090
Closed
joakime added a commit that referenced this issue Jul 12, 2023
@joakime
Issue #10055 - Ensure that strong quoting is done only when needed, a…
a325d2f 
…nd escaping is done properly.

Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jul 12, 2023
@joakime
Issue #10055 - Handle unicode suspiciously (shell quoting always)
74195a3 
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime mentioned this issue Jul 12, 2023
Closed
sbordet added a commit that referenced this issue Jul 14, 2023
@gregw @sbordet
Fixes #9999 and #10055 - proper quoting for dry-run
11d2a32 
Using "strong quoting" with the single quote character to quote argument of --dry-run output.

Signed-off-by: gregw <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Co-authored-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor

sbordet commented Jul 14, 2023 •
edited
Loading

Fixed by #10099, merged to 12.

After the merge, this is the output:

/home/simon/programs/openjdk-20.0.1+9/bin/java
-Djava.io.tmpdir=/tmp
-Djetty.home=/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home
-Djetty.base=/tmp/jetty.base
--class-path
/tmp/jetty.base/resources:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/logging/slf4j-api-2.0.7.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/logging/jetty-slf4j-impl-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-http-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-server-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-xml-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-util-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-io-12.0.0-SNAPSHOT.jar:/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/jetty-deploy-12.0.0-SNAPSHOT.jar
org.eclipse.jetty.xml.XmlConfiguration
java.version=20.0.1
jetty.base=/tmp/jetty.base
jetty.base.uri=file:///tmp/jetty.base
jetty.home=/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home
jetty.home.uri=file:///home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home
jetty.webapp.addServerClasses=org.eclipse.jetty.logging.,file:///home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/lib/logging/,org.slf4j.
runtime.feature.alpn=true
slf4j.version=2.0.7
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty-bytebufferpool.xml
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty-threadpool.xml
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty.xml
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty-deploy.xml
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty-http.xml
--env
core
contextHandlerClass='org.eclipse.jetty.server.handler.ResourceHandler$ResourceContext'
/home/simon/opensource/jetty/12.0/jetty-home/target/jetty-home/etc/jetty-core-deploy.xml

In particular:

--env core contextHandlerClass='org.eclipse.jetty.server.handler.ResourceHandler$ResourceContext'

Shows that the $ has been detected and the value properly quoted.

@sbordet sbordet closed this as completed Jul 14, 2023
@sbordet sbordet moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta4 Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved start.jar dry-run command line quoting jetty/jetty.project
3 participants
@gregw @sbordet @lachlan-roberts