-
Notifications
You must be signed in to change notification settings - Fork 49
Change threshold to greater than or equal to #501
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @simonswine |
Signed-off-by: Luke Addison <[email protected]>
e0f5ca6
to
4286ee0
Compare
/assign @dippynark A bit more background: how have you discovered this?. The UI shows it somehow like that: I might have understood it. The sum of 2 datapoints needs to be |
@simonswine these blog posts https://aws.amazon.com/blogs/aws/new-auto-recovery-for-amazon-ec2/ and https://aws.amazon.com/blogs/aws/ec2-instance-status-metrics/ Not sure where you are seeing that but it may be grouping them over certain periods. The metric we are setting up is using the minimum so it'd give different results |
@dippynark: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it: The
StatusCheckFailed_System
is a binary value so we must check for when the metric equals one