-
Notifications
You must be signed in to change notification settings - Fork 49
Adds flag to use own AWS key pair #315
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
145ec60
to
d72fa00
Compare
/cc @dippynark |
/assign @dippynark |
/assign @simonswine |
I think this should be a configuration option in the tarmak.yaml for the aws provider (and should have the option to be overriden in AWS specific sections of environment,clusters or instancePools) /unassign |
@JoshVanL: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoshVanL: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Adds a flag to use an existing key pair in AWS.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #312Release note: