-
Notifications
You must be signed in to change notification settings - Fork 31
Feed the stdout and stderr of the Pilot subprocess into glog #167
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test e2e |
cb0ba98
to
98e912f
Compare
/test e2e |
01af37b
to
85dfd2b
Compare
/test e2e |
85dfd2b
to
683a73c
Compare
/test e2e |
683a73c
to
c0b1aa5
Compare
/test e2e |
cc83e38
to
45bf286
Compare
@wallrj PR needs rebase |
45bf286
to
dbce519
Compare
@wallrj PR needs rebase |
dbce519
to
8ac9d9f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
e.g.
|
@wallrj PR needs rebase |
Digging this old PR back up... We've discussed making it easier to distinguish app logs from Pilot itself - I definitely think we should do that, however I am not sure if pushing those logs into glog like this helps that goal. @cehoffman what are your thoughts? In 'optimal' operating conditions, Pilot should be pretty silent. I think right now Navigator sets the |
Fixes: #166
Release note: