-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CosmosStore): Expose ISyncContext.SessionToken #195
Draft
bartelink
wants to merge
3
commits into
master
Choose a base branch
from
sessiontoken
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
sessiontoken
branch
from
February 19, 2020 02:40
ca37dac
to
9bb0650
Compare
bartelink
force-pushed
the
sessiontoken
branch
from
February 19, 2020 03:59
9bb0650
to
40b1387
Compare
bartelink
force-pushed
the
master
branch
5 times, most recently
from
March 23, 2020 15:38
ac7e783
to
4305b88
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
October 9, 2020 08:07
cd5febc
to
e92891c
Compare
bartelink
force-pushed
the
master
branch
9 times, most recently
from
October 30, 2020 10:59
22cfdd4
to
644aaa2
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
May 13, 2022 21:13
b1a5694
to
a7486eb
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
May 30, 2022 10:43
1919c31
to
b7e2207
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
June 5, 2023 16:06
fe2af41
to
edda98d
Compare
bartelink
changed the title
Add Sessiontoken
feat(Cosmosstore): Expose ISyncContext.SessionToken
Jul 26, 2023
bartelink
changed the title
feat(Cosmosstore): Expose ISyncContext.SessionToken
feat(CosmosStore): Expose ISyncContext.SessionToken
Jul 26, 2023
bartelink
force-pushed
the
master
branch
5 times, most recently
from
December 15, 2023 11:05
7053335
to
07a8d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a
SessionToken
onEquinox.Core.ISyncState
, which enables logic in aService
to access that (along with theVersion
plumbed in #194) via theQueryEx
andTransactAsyncEx
APIs. More importantly, it enables one to flow theSessionToken
out to the caller in order to enable Read-Your-Writes guarantees for a system's overall client session.This could be merged in the 2.0 timeframe, but leaving it in the 3.0 milestone for now as doing so only makes sense if
Equinox.Cosmos
(or another store) actually wires through theSessionToken
correctly, which involves addressing #192:Equinox.Stream
, one needs to be able to supply the incomingSessionToken
(maybe add asessionToken
argument inResolve
?Load
internally, the suplied token needs to be passed in the OptionsStreamToken
that's yielded backcc @thednaz @ylibrach