Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SystemTextJson): Encoding with conditional compression #126

Merged
merged 16 commits into from
Jan 29, 2025
Merged

feat(SystemTextJson): Encoding with conditional compression #126

merged 16 commits into from
Jan 29, 2025

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Dec 31, 2024 •
edited
Loading

Adds Encoder.Uncompressed and Encoder.TryCompress to SystemTextJson to enable compression to be managed external to the storage layer as per the Equinox DynamoStore implementation.

Used in Equinox.CosmosStore v 4.1.0 and later to facilitate:

  • improved compression via use of Brotli
  • better control of what to compress or not (selecting per event case, compressing events, only selectively compressing snapshots etc)
  • more complete control of testing of encoding vs event generation in integration test scenarios
  • simpler API for Equinox.CosmosStore (and better symmetry with DynamoStore, which makes the overall stack easier to grok)

@bartelink bartelink mentioned this pull request Dec 31, 2024
Closed
@bartelink bartelink force-pushed the stj-trycompress branch 3 times, most recently from 6c76c84 to f94eea0 Compare December 31, 2024 10:34
@bartelink bartelink changed the title feat(SystemTextJson): Compression feat(SystemTextJson): Conditional Compression / Encoding Dec 31, 2024
@bartelink bartelink mentioned this pull request Dec 31, 2024
Open
@bartelink bartelink force-pushed the stj-trycompress branch 5 times, most recently from 8875e8c to 49a47d7 Compare January 2, 2025 00:59
@bartelink bartelink changed the base branch from master to mapex January 2, 2025 01:00
@bartelink bartelink changed the title feat(SystemTextJson): Conditional Compression / Encoding feat(SystemTextJson): Encoding with conditional compression Jan 2, 2025
@bartelink bartelink force-pushed the stj-trycompress branch 3 times, most recently from 505c91f to 1b2cb49 Compare January 3, 2025 23:11
bartelink
bartelink commented Jan 4, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Base automatically changed from mapex to master January 29, 2025 19:17
@bartelink bartelink force-pushed the stj-trycompress branch 3 times, most recently from faf77de to 112505d Compare January 29, 2025 20:47
@bartelink bartelink merged commit 309fb78 into master Jan 29, 2025
9 checks passed
@bartelink bartelink deleted the stj-trycompress branch January 29, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartelink