Allow module field #5460
Closed
Allow module field #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I just noticed in my own project, that this will fail with some packages. Webpack is able to do this right, maybe we can steal the idea on how to do it from them. |
|
Thanks for sending a PR! See #2704 for a longer discussion, and more code 🙂I'd suggest copying that approach, rebase it, and se where we're at. |
|
Agreed, reviving #2704 is probably the best idea :) |
|
Seems like that PR is a lot further than this one, yes. |
|
I reopened the old PR here: #5485 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
jestalways resolves dependencies through themainfield in thepackage.json. This PR will allow packages to also be imported through themodulefield.Why is this needed?
According to the new
modulefield proposalnode.jswill start preferringmoduletomain.Real world example
I have a project where I depend heavily on yarn workspaces. I use the
moduleand themainfield to distinguish between compiled and non-compiled files. So themodulefield actually refers to the actual source code of the required dependency. When it would justrequirethemainfield it would load the compiled files, which would make it harder to debug around different packages.