-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pnpm round 2 #1046
base: master
Are you sure you want to change the base?
feat: add support for pnpm round 2 #1046
Conversation
Pull Request Test Coverage Report for Build 5497229823
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robmcguinness Thanks for the PR. It looks good.
Before we go ahead with this, just want to double-check that you have tested it with a pnpm project without the debug config in launch.json
, and you were able to use the plugin to generate a default config to debug the test. That means you should see this message in the test terminal when you debug the test:
No debug config named "vscode-jest-tests.v2" or "vscode-jest-tests" found in launch.json, will use a default config.
@connectdotz seems like there is more work todo. I tried using plugin to generate default config for debugging. Here are the results with ./node_modules/.bin/jest --runInBand --watchAll=false --testNamePattern "" --runTestsByPath ""
Debugger attached.
Waiting for the debugger to disconnect...
[workspace root]/node_modules/.bin/jest:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
^^^^^^^
SyntaxError: missing ) after argument list
at internalCompileFunction (node:internal/vm:73:18)
at wrapSafe (node:internal/modules/cjs/loader:1176:20)
at Module._compile (node:internal/modules/cjs/loader:1218:27)
at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
at Module.load (node:internal/modules/cjs/loader:1117:32)
at Module._load (node:internal/modules/cjs/loader:958:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47 Reference article that had similar problem https://dev.to/elpddev/debug-jest-spec-in-vscode-error-missing-after-argument-list-1p3b I'll try and dig further. |
Thanks for digging, a few thoughts:
|
Hi @connectdotz, it's been a while. Let me know if you'd want to write a test for this. I've recently used the WebdriverIO VS Code Testing Service to test another extension and could set that up pretty quickly (in a separate Issue and PR). |
@seanpoulter, nice to see you here! 😃 I dropped the ball on this issue, it would be great if you could test this against a pnpm workspace! Thanks! |
Sorry I have not been able to circle back on this. |
Any updates on this? |
Credit to original PR #1033. This includes unit tests.
code --extensionDevelopmentPath=your-local-vscode-jest
and seemed to work fine 🤞🏼yarn test
passedyarn vscode:prepublish
seemed to workCloses #974